[WIP] Fix NetworkManager EventTargetParser #921
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@Niccolo-Alfredo I wonder if you could help with some examples of other payloads here? |
|
Hi @agrare! Yes, absolutely. I agree that a more complete solution is needed for the Network Manager's target parsing. I have opened a new Pull Request, #930, which proposes a comprehensive fix and enhancement for the The PR includes logic to correctly handle various resource targets (like Ports, Security Groups, etc.) from modern OpenStack event payloads, addressing the need for better targeting examples. Please feel free to review the changes directly in PR #930. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some event payload types don't have a
resource_idin the payload, but they do have e.g.{"network" => {"id" => ...}}Ref: https://github.com/orgs/ManageIQ/discussions/23589